Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo of lit update error #10271

Closed
wants to merge 2 commits into from
Closed

demo of lit update error #10271

wants to merge 2 commits into from

Conversation

aleksandrjet
Copy link
Contributor

@aleksandrjet aleksandrjet commented Feb 29, 2024 •
edited

Demo of lit update error without adding dependencies
Fix - https://github.com/withastro/astro/pull/10267/files

@aleksandrjet aleksandrjet marked this pull request as draft February 29, 2024 09:31
@aleksandrjet aleksandrjet marked this pull request as ready for review February 29, 2024 09:31
@aleksandrjet aleksandrjet changed the title see lit error Demo of lit update error Feb 29, 2024
@aleksandrjet aleksandrjet changed the title Demo of lit update error demo of lit update error Feb 29, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 29, 2024 •
edited

⚠️ No Changeset found

Latest commit: a86fe61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Feb 29, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 29, 2024

⚠️ No Changeset found

Latest commit: a86fe61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ematipico
Copy link
Member

Some tests are failing @aleksandrjet

@aleksandrjet
Copy link
Contributor Author

Some tests are failing @aleksandrjet

@ematipico yes, I made this pr as demo for https://github.com/withastro/astro/pull/10267/files, because I needed to show that the tests failed. It shows that we need to add some deps to integrations/lit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aleksandrjet @ematipico @florian-lefebvre