Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FindSubstring<&[u8]>: make use of memchr::memmem #86

Merged
merged 1 commit into from
Jan 27, 2023
Merged

FindSubstring<&[u8]>: make use of memchr::memmem #86

merged 1 commit into from
Jan 27, 2023

Conversation

epage
Copy link
Collaborator

@epage epage commented Jan 27, 2023

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4020509114

  • 1 of 293 (0.34%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-4.8%) to 51.153%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/traits.rs 0 292 0.0%
Files with Coverage Reduction New Missed Lines %
src/character/complete.rs 1 79.58%
Totals Coverage Status
Change from base Build 4019581529: -4.8%
Covered Lines: 1753
Relevant Lines: 3427
💛 - Coveralls

@epage epage merged commit c03363f into winnow-rs:main Jan 27, 2023
@epage epage deleted the memchr branch January 27, 2023 00:56
@epage epage mentioned this pull request Aug 17, 2023
Merged
epage added a commit to epage/winnow that referenced this pull request Aug 17, 2023
@epage
perf(token): Speed up take_until under simd
ba7bb2d 
This reverts commit 489aa2a.

PR winnow-rs#86 "FindSubstring<&[u8]>: make use of `memchr::memmem`"

When testing under gitoxide, it turned out this slowed down
gitoxide-specific micro-benchmarks from ~170ns to ~240ns
This was referenced Aug 17, 2023
Merged
Open
epage added a commit to epage/winnow that referenced this pull request Aug 17, 2023
@epage
perf(token): Speed up take_until under simd
c33acf5 
This reverts commit 489aa2a.

PR winnow-rs#86 "FindSubstring<&[u8]>: make use of `memchr::memmem`"

When testing under gitoxide, it turned out this slowed down
gitoxide-specific micro-benchmarks from ~170ns to ~240ns
epage added a commit to epage/winnow that referenced this pull request Aug 17, 2023
@epage
perf(token): Speed up take_until under simd
7736667 
This reverts commit 489aa2a.

PR winnow-rs#86 "FindSubstring<&[u8]>: make use of `memchr::memmem`"

When testing under gitoxide, it turned out this slowed down
gitoxide-specific micro-benchmarks from ~170ns to ~240ns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@epage @coveralls @homersimpsons