Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart button added and restore the previous part #116

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

devendra66
Copy link

features #60

"I have recently implemented several enhancements to our application. First, I've introduced a 'Restart' button, allowing users to restart the quiz in case of failure. This feature enhances the user experience by giving them a second chance to improve their performance.

In addition, I have added comments to indicate whether a user has passed or failed the quiz. These comments provide valuable feedback and improve user engagement throughout the quiz.

Furthermore, I've successfully resolved an issue where the initial page was not loading correctly. This ensures a smooth starting point for users accessing the quiz.

These updates reflect my commitment to enhancing the application's usability and functionality, with the goal of delivering a more satisfying experience to our users

Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please run lint. don't use your IDE linting.
  2. same problem. in Quiz.jsx, you inverted start, which already breaks the existing features. you can check disableSynopsis, which is easy to spot.

@devendra66
Copy link
Author

what command I should run to enable lint pls tell😊

@wingkwong
Copy link
Owner

npm run lint

@devendra66
Copy link
Author

Screenshot 2023-10-03 191845

It is showing this error I have also searched in stackover no solution to it please tell what to do :)

@wingkwong
Copy link
Owner

Please ping me at Discord.

Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to have a variable to control whether to show restart button or not.

src/lib/Core.jsx Outdated Show resolved Hide resolved
src/lib/Core.jsx Outdated Show resolved Hide resolved
src/lib/Core.jsx Outdated Show resolved Hide resolved
src/lib/Core.jsx Outdated Show resolved Hide resolved
Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still we need a prop called allowRestart so that users can configure whether to show it or not.

src/lib/Core.jsx Outdated Show resolved Hide resolved
Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please remove those /*eslint-disable*/ you added.
  2. allowRestart is missing

import React, { useState, useEffect, useCallback } from 'react';
import Core from './Core';
import defaultLocale from './Locale';
import './styles.css';

import quiz from '../docs/quiz';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not correct. docs is the app using lib. you are making infinite reference here. please remove this line.

@@ -139,6 +140,7 @@ const Quiz = function ({
allowNavigation={allowNavigation}
appLocale={appLocale}
onQuestionSubmit={onQuestionSubmit}
quiz={quiz}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to pass the entire object to it. You just need passingMarks.

} from "./core-components/helpers";
import InstantFeedback from "./core-components/InstantFeedback";
import Explanation from "./core-components/Explanation";
// import quiz from '../docs/quiz';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants