-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart button added and restore the previous part #116
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please run lint. don't use your IDE linting.
- same problem. in
Quiz.jsx
, you inverted start, which already breaks the existing features. you can checkdisableSynopsis
, which is easy to spot.
what command I should run to enable lint pls tell😊 |
|
Please ping me at Discord. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to have a variable to control whether to show restart button or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still we need a prop called allowRestart
so that users can configure whether to show it or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please remove those
/*eslint-disable*/
you added. allowRestart
is missing
import React, { useState, useEffect, useCallback } from 'react'; | ||
import Core from './Core'; | ||
import defaultLocale from './Locale'; | ||
import './styles.css'; | ||
|
||
import quiz from '../docs/quiz'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not correct. docs is the app using lib
. you are making infinite reference here. please remove this line.
@@ -139,6 +140,7 @@ const Quiz = function ({ | |||
allowNavigation={allowNavigation} | |||
appLocale={appLocale} | |||
onQuestionSubmit={onQuestionSubmit} | |||
quiz={quiz} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to pass the entire object to it. You just need passingMarks
.
} from "./core-components/helpers"; | ||
import InstantFeedback from "./core-components/InstantFeedback"; | ||
import Explanation from "./core-components/Explanation"; | ||
// import quiz from '../docs/quiz'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line
features #60
"I have recently implemented several enhancements to our application. First, I've introduced a 'Restart' button, allowing users to restart the quiz in case of failure. This feature enhances the user experience by giving them a second chance to improve their performance.
In addition, I have added comments to indicate whether a user has passed or failed the quiz. These comments provide valuable feedback and improve user engagement throughout the quiz.
Furthermore, I've successfully resolved an issue where the initial page was not loading correctly. This ensures a smooth starting point for users accessing the quiz.
These updates reflect my commitment to enhancing the application's usability and functionality, with the goal of delivering a more satisfying experience to our users