Fix width issue #262
Fix width issue #262
Conversation
Also, removed the `left` and `right` styles from the body, since those may not be present on the consuming project's styles.
|
Hey, I think we encountered the same issue that this PR fixed. We saw that setting Is there any known reason why this PR has not been approved? Great package, thanks! |
By setting the body's `right` style, width is calculated properly in Safari, which can avoid bugs in some situations where content width is wider than the page width.
joshuacurtiss
force-pushed
the
fix-width-issue
branch
from
1202f8e
to
59879a9
Compare
|
Is there any rough estimate for when this could be merged and released?🤞 |
I guess not 😔 2 years silence 😶 You can use https://github.com/tuax/tua-body-scroll-lock, i guess it will solve your problem (it solved mine) |
|
They stopped the repairs. I had to do it myself, in the same way, with a new version of typeScript. And fix these problems for everyone to use. add react hooks、vue3 example repair log，Refer to the releases page. |
Fixes #261. Details below! Thank you for this excellent project.
Adjustments to examples
I adjusted the samples to include traditional mobile responsive meta tag:
Then, I removed the
leftandrightstyles from thebodytag in the examples as well, since websites using this library may not have those styles and we can't expect that they will be there.Finally, I added some wide content that is wider than the page. This may be found, for instance, in pages with a carousel.
Fix
The fix is simple; just set the
rightstyle in addition to thetopandleft! Safari will no longer affect the width.Ran the bundle scripts for the main code as well as the example bundles.