Replacing legacy handshakeverify extension with one that uses cowpatty #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to validate the WPA key.
|
This pull request introduces 2 alerts when merging 041142c into 46bdf13 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 9ae7190 into 46bdf13 - view on LGTM.com new alerts:
|
sophron
reviewed
Apr 13, 2020
|
|
||
| def is_valid_handshake_capture(filename): | ||
| command = '/bin/cowpatty -c -r {}'.format(filename) |
There was a problem hiding this comment.
Can we return an error if cowpatty is not installed?
There was a problem hiding this comment.
Ok, I willl accomplish it as soon as possible.
|
I'll fix this and merge it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to problems with python3 porting, I think it would be better to use a tool like cowpatty to ensure WPA key validation.