Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pandas dataframe transpose display error #613

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

SarthakNikhal
Copy link

Fix for #526.
Created a separate variable to store row names to display them correctly as per the index in the loop.
Also, created a new function in utils to cater for getting list of row index names just like for columns.

Copy link
Contributor

@maartenbreddels maartenbreddels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you @SarthakNikhal !
See my comment in the code, hope they make sense.

solara/lab/hooks/dataframe.py Outdated Show resolved Hide resolved
solara/components/datatable.py Outdated Show resolved Hide resolved
solara/components/datatable.py Outdated Show resolved Hide resolved
solara/lab/utils/dataframe.py Outdated Show resolved Hide resolved
solara/lab/utils/dataframe.py Outdated Show resolved Hide resolved
solara/components/datatable.py Outdated Show resolved Hide resolved
@SarthakNikhal
Copy link
Author

@maartenbreddels Completed the changes.

@iisakkirotko
Copy link
Collaborator

Hey @SarthakNikhal!

Looks like there are only two code quality errors left. Take a look at running pre-commit run --all-files to see them locally (this should also autofix the second one, at least).

@SarthakNikhal
Copy link
Author

Done. I did not know about pre-commit. Thanks!

@iisakkirotko
Copy link
Collaborator

Nice, thanks a lot @SarthakNikhal!

I think the changes to .pre-commit-config.yaml and to the packages/solara-widget-manager8 directory need to be reverted for CI to pass, otherwise this looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants