Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Test against Python 3.10 #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CI: Test against Python 3.10 #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codequality.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.7, "3.9"]
python-version: [3.7, "3.10"]

steps:
- uses: actions/checkout@v2
Expand Down
13 changes: 6 additions & 7 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,13 @@ jobs:
# just ubuntu and windows give enough confidence
# osx should work fine (and we test that locally often)
os: [ubuntu, windows]
# just 1 version, it's heavy
python-version: [3.8]
ipywidgets: ["7.7", "8.0"]
include:
- ipywidgets: "7.7"
voila: "0.3.0"
- ipywidgets: "8.0"
voila: "0.4.0"
- ipywidgets: "7.8"
voila: "0.3.7"
python-version: "3.10"
- ipywidgets: "8.1"
voila: "0.5.4"
python-version: "3.10"
Comment on lines +29 to +34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we use a ~ for the installation, so this change is not needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see that you have changed the matrix from 2x2 to 1x2. I think ipywidsgets should be kept top level for the matrix to work.


steps:
- uses: actions/checkout@v2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/javascript.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Set up Python 3.7
- name: Set up Python 3.10
uses: actions/setup-python@v2
with:
python-version: 3.7
python-version: "3.10"
- uses: actions/setup-node@v3
with:
node-version: 14
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Set up Python 3.7
- name: Set up Python 3.10
uses: actions/setup-python@v2
with:
python-version: 3.7
python-version: "3.10"
- uses: actions/download-artifact@v2
with:
name: solara-builds-${{ github.run_number }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/unittest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu, macos, windows]
python: [3.6, 3.9]
ipywidgets: ["7.7", "8.0"]
python: ["3.6", "3.10"]
ipywidgets: ["7.8", "8.1"]
exclude:
- os: windows
python: 3.6
- os: ubuntu
python: 3.6
ipywidgets: "8.0"
ipywidgets: "8.1"
- os: macos
python: 3.6
ipywidgets: "8.0"
ipywidgets: "8.1"

steps:
- uses: actions/checkout@v2
Expand Down