Split PlayerCommand into smaller files #6424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigned to Nordfriese |
bunnybot
added
ci:success
bunnybot
added
ci:success
bunnybot
added
ci:success
bunnybot
added
ci:success
bunnybot
added
ci:success
bunnybot
added
ci:success
bunnybot
added
ci:success
bunnybot
added
ci:success
bunnybot
added
ci:success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created on Sun Mar 31 09:37:04 CEST 2024 by Benedikt Straub (Nordfriese)
Type of change
Refactoring
Issue(s) closed
Big source file are evil. As a rule of thumb, a file shouldn't be longer than 500 lines, and more than 1000 lines is too big.
This splits the huge player commands file into a whole directory of smaller files, and also moves other game command types there for consistency.
Since I'm already at it, a little refactoring especially around names (e.g. "enemyflagaction" → "attack").
Possible regressions
All kinds of commands and their handling.
Will have merge conflicts with several other PRs, regardless of the order of merging.