Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org.widelands.Widelands.appdata.xml #6404

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fpiesche
Copy link

Type of change
Bugfix

Issue(s) closed

This fixes a deprecation warning during Flatpak builds; the developer_name node is no longer supported in AppStream 1.0.

Additional context
Additionally, this now enables the "The Widelands Development Team" string to be translated if so desired, by translating the <name> node as with other translatable elements in the metadata file.

This fixes a deprecation error during Flatpak builds; the `developer_name` node is no longer supported in AppStream 1.0.
@bunnybot
Copy link

Mirrored on Codeberg as #CB4766.

@tothxa
Copy link
Member

tothxa commented Mar 12, 2024

Please note that …Widelands.appdata.xml is an autogenerated file. You have to edit …appdata.xml.stub. To make the name actually translatable, you have to introduce a new hook in that file, by also editing utils/update_appdata.py, and put the actual translatable data in xdg/translations/appdata.json.

@tothxa tothxa added this to the v1.3 milestone Mar 12, 2024
@tothxa tothxa added documentation Improvements or additions to documentation internationalization Translation system, string fixes, RTL support building & packaging Building, packaging, continuous integration, appdata, cmake labels Mar 12, 2024
@tothxa
Copy link
Member

tothxa commented Mar 23, 2024

Please note that …Widelands.appdata.xml is an autogenerated file. You have to edit …appdata.xml.stub. To make the name actually translatable, you have to introduce a new hook in that file, by also editing utils/update_appdata.py, and put the actual translatable data in xdg/translations/appdata.json.

@fpiesche Please let me know if you are interested in doing all the above. Otherwise I can take it over.

@fpiesche
Copy link
Author

I'm about to move house on Thursday so am unlikely to have time for the next couple of weeks - I'd generally be happy to do it though, so if you're okay with this sitting idle for a bit I'll get back to it once that's all over :)

@tothxa
Copy link
Member

tothxa commented Mar 23, 2024

That's OK. It's not urgent, and I have plenty of other things to do too. (both around Widelands and unfortunately also in my private life... :( )

@bunnybot bunnybot mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building & packaging Building, packaging, continuous integration, appdata, cmake documentation Improvements or additions to documentation internationalization Translation system, string fixes, RTL support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants