Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for images, any maybe other file types? 馃槃 #754

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cal2195
Copy link
Collaborator

@cal2195 cal2195 commented Apr 23, 2022

Just a WIP, adding support for images.

Should be super simple, just work out how to deal with image strips and clips (basically don't), and allow for toggling video and images individually! 馃挕

Thoughts?

@cal2195 cal2195 added the 鉀戯笍 WIP Work in progress label Apr 23, 2022
@cal2195 cal2195 requested a review from whyboris April 23, 2022 10:17
@cal2195 cal2195 self-assigned this Apr 23, 2022
@whyboris
Copy link
Owner

whyboris commented Apr 24, 2022

Hey Cal! Great to "see" you again 馃榿

Thank you for this suggestion / start of a discussion.

I started (50% finished?) Simple Image Browser application: https://github.com/whyboris/Simple-Image-Browser (SIB) which might be just what people keep asking me about when they say they want images in VHA. Before I add image types to VHA, I'd like to get the dedicated image browser released first 馃槄 .

I've felt rather strongly against mixing image and video browsing inside one application, but I see how someone might have images that are associated with some videos and it may be useful to see those all in one place. Coding it up and making the UI for it feels like would be quite nightmarish for my app. I guess I could create an image-only gallery view which would just show images inside a folder without keeping to the 16:9 video resolution; perhaps, I could just use the functionality of the Simple Image Browser of not even extracting screenshots, but simply displaying images live 馃 ... but at that point I'd just be making a crappier version of SIB 馃し

I'll definitely consider it once I've released SIB 馃

@cal2195
Copy link
Collaborator Author

cal2195 commented Apr 24, 2022

The way I'm thinking of it, is that images are just like a video, but with a single frame. When you think of it that way, there's very little to change, and you get all the benefits of what VHA already does extremely well. 馃挕

The code should basically be identical, just with less features available for images. 馃

And I'm planning on having a toggle for importing/displaying images or videos, so it's totally optional anyway.

My current plan for phase one anyway, is just that. Not even image viewing in app - just like videos, click an image, and your default image viewer opens. (This already just works actually 馃槀 ).

Thoughts on this view?

@cal2195
Copy link
Collaborator Author

cal2195 commented Apr 24, 2022

I've a few more features and improvements I'd like to add to VHA, so if you'd still like to hold off, I'll create and integration branch on my repo for this and future changes, and still try to make pull requests on your main branch. 馃槃

@cal2195
Copy link
Collaborator Author

cal2195 commented Apr 24, 2022

I could just use the functionality of the Simple Image Browser of not even extracting screenshots, but simply displaying images live

Thumbnails are much more performant, especially when images get large (raw files), and if you access them over a network on a NAS somewhere. And it's super easy to piggy back off ffmpeg for this - I see it's already done in VHA for replacing your own thumbnail! 馃槃

@cal2195 cal2195 marked this pull request as draft April 24, 2022 21:38
@whyboris
Copy link
Owner

I'm certainly open to this possibility. I guess in the home.component.html where we feed all the imageElements into the view, the first pipe could be the image / video toggle 馃

https://github.com/whyboris/Video-Hub-App/blob/main/src/app/components/home.component.html#L691

And then after that, just about nothing else needs to change 馃憤

So you are probably right -- if the weird 16:9 view is acceptable (with black letterboxing; which in Dark Mode would be invisible anyway) then the number of changes we need to get this working might be pretty small 馃

Thanks as usual for excellent ideas and actual additions to the app 馃檱

I've not thought through all the implications of having images, but it seems like we'll automatically inherit tags 馃し which I guess some people want (馃し ?).

The one minor worry is about .vha2 growing mighty large, but I think even with 100,000 items the app should survive fine 馃

I'm open to a PR that does something like this -- and/or a variation -- I'm open to recommendations 馃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
鉀戯笍 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants