Remove CIP-42 support #2187
Closed
Remove CIP-42 support #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: baa5116 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@shazarre is attempting to deploy a commit to the wevm Team on Vercel. A member of the Team first needs to authorize it. |
|
for more context CIP42 has been deprecated since gingerbreadhardfork and transactions sent to blockchain using this format will not be executed in following hardfork. |
1 task
github-merge-queue bot
pushed a commit
to valora-inc/wallet
that referenced
this pull request
May 3, 2024
### Description We're actually already using CIP64 TXs, but the type we import still is CIP42. And it's going away soon: wevm/viem#2187 ### Test plan - Typecheck passes ### Related issues N/A ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
jxom
force-pushed
the
main
branch
3 times, most recently
from
f4447d7
to
1a0731f
Compare
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description We're actually already using CIP64 TXs, but the type we import still is CIP42. And it's going away soon: wevm/viem#2187 ### Test plan - Typecheck passes ### Related issues N/A ### Backwards compatibility Yes ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
|
Superseded by #2277. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated CIP-42 transaction type support for Celo in favour of CIP-64.
It still keeps functionality to parse and format existing CIP-42 transactions that can be retrieved directly from the blockchain.
PR-Codex overview
This PR removes support for CIP-42 and treats all transactions with a
feeCurrencyfield as CIP-64.Detailed summary
feeCurrencyare treated as CIP-64