refactor: split icons to packages #255
Merged
+163
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will reduce the bundle size as `icons.ts` non-gzipped weights around 1.2MB and is always being imported when `frog/ui` package is used. We can improve the bundle size by splitting the icons into different packages, having just one collection imported by default – lucide.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@dalechyn is attempting to deploy a commit to the wevm Team on Vercel. A member of the Team first needs to authorize it. |
dalechyn
commented
Apr 14, 2024
dalechyn
added
D: Medium
tmm
requested changes
May 15, 2024
Co-authored-by: awkweb <[email protected]>
tmm
approved these changes
May 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #240 by decreasing the bundle size by splitting icons in multiple proxy packages.
As of now, all icons are imported even if just one set is used.