Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment totalRows and pageSize on row insertion in server mode #7312

Closed
wants to merge 5 commits into from

Conversation

OnlyPassionCode
Copy link

@OnlyPassionCode OnlyPassionCode commented May 1, 2024

馃Type of Request

  • Bug
  • Core

鈽戯笍Self Check before Merge

鈿狅笍 Please check all items below before reviewing. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@wenzhixin
Copy link
Owner

Please provide an Online Example to show your problem. Thanks!

@OnlyPassionCode
Copy link
Author

Please provide an Online Example to show your problem. Thanks!

Here is a example : https://live.bootstrap-table.com/code/OnlyPassionCode/17570

@wenzhixin
Copy link
Owner

After Example: https://live.bootstrap-table.com/code/wenzhixin/17572 with your branch.

@OnlyPassionCode
Copy link
Author

After Example: https://live.bootstrap-table.com/code/wenzhixin/17572 with your branch.

I just made a correction.

In fact when inserting data, I increased the pageSize variable by 1 but the problem is that this variable is not reset during the next initServer.
So I created a backUp system in order to reset this pageSize variable.
Additionally, now in the insertRow the this.data variable contains the options data, why is this important? This is due to another bug which consists of when we add a row at index 0 and we want to modify the row at index 1 by clicking on it for example and the event gives us the 'index 1 but actually gives us the row with index 2 because he did not put our new row in this.data because we are in server mode.

@OnlyPassionCode
Copy link
Author

Here is an example of a use case where we would like to retrieve the row clicked following the insertion of a row :
https://live.bootstrap-table.com/code/OnlyPassionCode/17573

@OnlyPassionCode
Copy link
Author

Here is an example of the final usage, but I don't understand.
The libraries section does not take my latest commits and therefore it does not work.

https://live.bootstrap-table.com/code/OnlyPassionCode/17574

@OnlyPassionCode
Copy link
Author

I'm going to work on a cleaner system closer to that of client mode. And of course the debugs of the bugs that I cited too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants