Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge wscat2 #30

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Merge wscat2 #30

wants to merge 45 commits into from

Conversation

nwwells
Copy link
Collaborator

@nwwells nwwells commented Jan 24, 2017

No description provided.

dstillman and others added 14 commits February 15, 2015 15:38
Show code and reason for non-1000 close events from server
Used with --connect, reconnects on disconnection or error. After 4 retries the user is prompted for action before trying again.

Useful when debugging a local server that's restarted during development since your command history is intact.
Added ParseCommands and KeepAlive options, plus frame counting and
connection timers.

ParseCommands option allows you to send ping, pong or message frames,
display last message received, and the frame counters.

Keep alive allows you to send a ping frame on a timer to keep your
connection alive.
@nwwells nwwells self-assigned this Jan 24, 2017
@nwwells nwwells mentioned this pull request Jan 24, 2017
@nwwells
Copy link
Collaborator Author

nwwells commented Jan 24, 2017

Looking at this... this is going to be tricky, and I think I'm going to need @jnordberg's help if we want to do this successfully. First of all, @jnordberg, are you interested in merging the projects?

@jnordberg
Copy link
Contributor

Sure! I can take a look at getting this merged when I have some time.

@jnordberg
Copy link
Contributor

Hey everyone! I started sorting out this merge but realised pretty fast that I'd rather rewrite the entire project from scratch, so I did that instead :)

I always wanted wscat to behave more like netcat allowing you to use it in test scripts etc. My rewrite removes a lot of functionality and probably this is not what everyone wants.

To remedy this my suggestion is to create a separate project called wsterm that replaces the functionality wscat won't have any more. Where the focus is being a debug terminal for web sockets.

Let me know what you think!

@jnordberg
Copy link
Contributor

New version is here https://github.com/jnordberg/wscat

jnordberg and others added 4 commits April 25, 2017 18:25
Add ts-node to dev dependencies and use that directly instead of relying on globally installed version
Copy link
Collaborator Author

@nwwells nwwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long on the review...

Overall, I think the rewrite and splitting out wsterm is a good thing. I also like that you broke things out into reasonable modules.

I think the following options need to be supported for approval:

    -p, --protocol <version>      optional protocol version
    -o, --origin <origin>         optional origin
    --host <host>                 optional host
    -s, --subprotocol <protocol>  optional subprotocol
    -n, --no-check                Do not check for unauthorized certificates
    -H, --header <header:value>   Set an HTTP header. Repeat to set multiple. (--connect only)
    --auth <username:password>    Add basic HTTP authentication header. (--connect only)
    --ca <ca>                     Specify a Certificate Authority (--connect only)
    --cert <cert>                 Specify a Client SSL Certificate (--connect only)
    --key <key>                   Specify a Client SSL Certificate's key (--connect only)
    --passphrase [passphrase]     Specify a Client SSL Certificate Key's passphrase (--connect only). If you don't provide a value, it will be prompted for.

I think we can collaborate on getting these in. shouldn't be too hard. What do you think?


WebSocket cat.
wscat2 [![Build Status](https://travis-ci.org/jnordberg/wscat.svg?branch=master)](https://travis-ci.org/jnordberg/wscat)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be wscat, no?

README.md Outdated

```
$ wscat -h
usage: wscat [-h] [-v] [-l PORT] [-b] [-k] [-d] [address]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're missing client tls support here?

ArtiomL and others added 7 commits December 8, 2017 00:31
* WebSocket subprotocol

* Subprotocol help

* Sort subprotocol keys

* ICLIOptions fix

* Update Makefile

* Update Makefile

* Fix IOptions
And add a package-lock.json
@septatrix
Copy link

Has there been any recent progress on this? The last update seems to be from 2 years ago but it is a feature which should not be missing in this toolkit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants