Pass to bash instead of running the string as arguments #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need it to be compatible with other actions.
Plus we set `-euo pipefail` by default to prevent dumb accidents.
Otherwise it fails on ``` /etc/bashrc: line 4: __ETC_BASHRC_SOURCED: unbound variable ```
-euo will stumble on unbound variables in /etc/profile for some reason. I thought --noprofile would disable that file, but looks like it’s sourced nonetheless? This is all very bad.
|
@adrians5j, can you please merge this? This action is currently quite hard to use, it doesn’t behave as expected. |
|
Hey @jirutka , sorry for the delay. The problem with the proposed changes is that the changes was made in built code, not in source. We should address that first, then we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the action behave similarly to the
runin step, which is passed tobash -e.I decided I wanted to have more security by default, so I use
-euo pipefail, but that could be changed.Iff this is merged, this should be a new major version of the action.