feat: use regex pattern to valid message #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current matching rules are slightly different from conventional commits |
pallabpain
suggested changes
Apr 16, 2023
| expect(isValidCommitMessage("fix(menus): menu must open on shortcut press")).toBe(true); | ||
| expect(isValidCommitMessage("🚧 fix(menus): menu must open on shortcut press")).toBe(true); | ||
| expect(isValidCommitMessage("🚧 fix(menus): menu must open on shortcut press")).toBe(false); |
There was a problem hiding this comment.
I feel that adding emojis to commit messages should be fine as long as the rest of the commit messages adheres to the conventional commits semantics.
| .replace(/[^a-z]/g, ""); // Only leave [a-z] characters. | ||
|
|
||
| return availableTypes.includes(possiblyValidCommitType); | ||
| let pattern = /^(build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test){1}(\([\w\-\.]+\))?(!)?: \S+([\s\S]*)/ |
There was a problem hiding this comment.
I'd rather the DEFAULT_COMMIT_TYPES be as it is and use
commitPrefixes = DEFAULT_COMMIT_TYPES.join("|");
to build the pattern. This makes it easier to extend the list of valid commit prefixes and improves readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.