Disable real time reporting APIs for mode A/B traffic. #46287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5539632
branch
5 times, most recently
from
d8434b4
to
0619116
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5539632
branch
4 times, most recently
from
fd57198
to
855e0bb
Compare
Also, 1. Added browser test for that. 2. Removed checking kRealTimeReporting flag in navigator_auction.cc when handling rtr fields, since these IDL fields are marked RunTimeEnabled, and these fields will just not show up when the flag is disabled. 3. Modify WPT expectations. Bug: 337132755 Change-Id: I61f5c0ebb96c2177574dc02fd90d7269b00f407c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539632 Commit-Queue: Qingxin Wu <[email protected]> Reviewed-by: mmenke <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1305132}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5539632
branch
from
855e0bb
to
3a28c6e
Compare
wpt-pr-bot
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also,
handling rtr fields, since these IDL fields are marked RunTimeEnabled,
and these fields will just not show up when the flag is disabled.
Bug: 337132755
Change-Id: I61f5c0ebb96c2177574dc02fd90d7269b00f407c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539632
Commit-Queue: Qingxin Wu <[email protected]>
Reviewed-by: mmenke <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1305132}