Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove old treeshaking #6549

Merged
merged 2 commits into from
May 22, 2024
Merged

chore: remove old treeshaking #6549

merged 2 commits into from
May 22, 2024
+291 −4,020

Conversation

JSerFeng
Copy link
Collaborator

Summary

Remove old treeshaking.

Remove builtins.treeshaking

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 15, 2024
@netlify Netlify
Copy link

netlify bot commented May 15, 2024 •
edited

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 0b8aa76
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/664db1de94f94c00087a6ae2

@JSerFeng JSerFeng force-pushed the rm-old-treeshaking branch 2 times, most recently from 7c6b1d3 to b029983 Compare May 16, 2024 03:16
@JSerFeng JSerFeng marked this pull request as draft May 16, 2024 03:16
@JSerFeng JSerFeng force-pushed the rm-old-treeshaking branch 6 times, most recently from c5b5a28 to 7269a3a Compare May 16, 2024 08:07
@JSerFeng JSerFeng marked this pull request as ready for review May 16, 2024 08:11
@JSerFeng JSerFeng marked this pull request as draft May 16, 2024 08:12
@JSerFeng
Copy link
Collaborator Author

!eco-ci

@rspack-bot
Copy link

rspack-bot commented May 16, 2024 •
edited

📝 Ran ecosystem CI: Open

suite result
modernjs ✅ success
nx ✅ success
rspress ✅ success
rsbuild ✅ success
compat ✅ success
examples ✅ success

@JSerFeng JSerFeng force-pushed the rm-old-treeshaking branch 6 times, most recently from e5c6dbe to 44dff1e Compare May 22, 2024 07:03
@JSerFeng JSerFeng marked this pull request as ready for review May 22, 2024 07:12
SyMind
SyMind previously approved these changes May 22, 2024
View reviewed changes
@JSerFeng
Copy link
Collaborator Author

!eco-ci

@rspack-bot
Copy link

rspack-bot commented May 22, 2024 •
edited

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
nx ✅ success
rspress ✅ success
rsbuild ✅ success
compat ✅ success
examples ✅ success

ahabhgk
ahabhgk previously approved these changes May 22, 2024
View reviewed changes
@JSerFeng JSerFeng dismissed stale reviews from ahabhgk and SyMind via 0b8aa76 May 22, 2024 08:50
@JSerFeng JSerFeng enabled auto-merge (squash) May 22, 2024 09:00
@JSerFeng JSerFeng merged commit 25edcdc into main May 22, 2024
29 checks passed
@JSerFeng JSerFeng deleted the rm-old-treeshaking branch May 22, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@SyMind SyMind SyMind left review comments

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz jerrykingxyz is a code owner

Assignees

@JSerFeng JSerFeng

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JSerFeng @rspack-bot @SyMind @ahabhgk