Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsearchable properties #4896

Closed
wants to merge 36 commits into from

Conversation

donomii
Copy link
Contributor

@donomii donomii commented May 10, 2024

What's being changed:

Fixes #4869

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

bennycortese and others added 25 commits February 22, 2024 03:22
Accidentally forgot to actually check the env - my bad
fix: don't return shutdown error incase the shard was already shutdow…
Revert "fix: don't return shutdown error incase the shard was already shutdow…" to re open against stable/v1.25
add retry on failure in CI for tests instability
Added an environment variable for disabling the go profiler setup
@donomii donomii self-assigned this May 10, 2024
dependabot bot and others added 4 commits May 13, 2024 06:41
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 5 to 6.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v5...v6)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…ngci/golangci-lint-action-6

Bump golangci/golangci-lint-action from 5 to 6
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@donomii donomii marked this pull request as ready for review May 14, 2024 13:26
@donomii donomii changed the base branch from main to stable/v1.25 May 15, 2024 10:40
@donomii donomii requested a review from a team as a code owner May 15, 2024 10:40
@donomii
Copy link
Contributor Author

donomii commented May 15, 2024

Replaced by #4930

@donomii donomii closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hybrid should skip properties with indexSearchable=False
7 participants