Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate contextionary url in dev setup #4806

Merged
merged 2 commits into from May 14, 2024

Conversation

aminst
Copy link
Contributor

@aminst aminst commented Apr 30, 2024

What's being changed:

There are duplicate CONTEXTIONARY_URL env variables in the run-dev-server file. This removes the unnecessary ones. This fixes #4764

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@aminst
Copy link
Contributor Author

aminst commented May 6, 2024

@trengrj Hi, I added the fix to the issue we discussed in #4806 here.

@aminst
Copy link
Contributor Author

aminst commented May 13, 2024

Hello @trengrj
The tests show that one test has failed, but I haven't changed anything related to the tests. How can I rerun the tests in the pipeline?

@trengrj trengrj merged commit bf46c3d into weaviate:main May 14, 2024
36 checks passed
@trengrj
Copy link
Member

trengrj commented May 14, 2024

Thanks @aminst I reran the tests and it looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate CONTEXTIONARY_URL in dev setup
2 participants