Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate CONTEXTIONARY_URL in dev setup #4764

Closed
aminst opened this issue Apr 25, 2024 · 1 comment · Fixed by #4806
Closed

Duplicate CONTEXTIONARY_URL in dev setup #4764

aminst opened this issue Apr 25, 2024 · 1 comment · Fixed by #4806

Comments

@aminst
Copy link
Contributor

aminst commented Apr 25, 2024

I was trying to run weaviate-server locally using the run_dev_server.sh file. I noticed there are unnecessary CONTEXTIONARY_URLs passed as environment variables.
There are multiple ones with the same issue in the run_dev_server file. For example:

 second-node)
      GRPC_PORT=50052 \
      CONTEXTIONARY_URL=localhost:9999 #HERE \
      AUTHENTICATION_ANONYMOUS_ACCESS_ENABLED=true \
      PERSISTENCE_DATA_PATH="./data-weaviate-1" \
      BACKUP_FILESYSTEM_PATH="${PWD}/backups-weaviate-1" \
      CLUSTER_HOSTNAME="weaviate-1" \
      CLUSTER_IN_LOCALHOST=true \
      CLUSTER_GOSSIP_BIND_PORT="7102" \
      CLUSTER_DATA_BIND_PORT="7103" \
      CLUSTER_JOIN="localhost:7100" \
      RAFT_PORT="8302" \
      RAFT_INTERNAL_RPC_PORT="8303" \
      RAFT_JOIN="weaviate-0:8300,weaviate-1:8302,weaviate-2:8304" \
      RAFT_BOOTSTRAP_EXPECT=3 \
      CONTEXTIONARY_URL=localhost:9999 # HERE \
      DEFAULT_VECTORIZER_MODULE=text2vec-contextionary \
      ENABLE_MODULES="text2vec-contextionary,backup-filesystem" \
      go_run ./cmd/weaviate-server \
        --scheme http \
        --host "127.0.0.1" \
        --port 8081 \
        --read-timeout=600s \
        --write-timeout=600s
    ;;

Is this intentional? I can fix it if this was not intended.

@trengrj
Copy link
Member

trengrj commented Apr 30, 2024

@aminst this is not intentional. Please feel free to raise a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants