aichat sidebar #633
Closed
aichat sidebar #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestDriver Summary |
esimkowitz
reviewed
May 2, 2024
| return { numLines, linePos }; | ||
| } | ||
|
|
||
| @mobx.action.bound |
There was a problem hiding this comment.
you'll need to add a constructor that calls mobx.makeObservable(this) in order for these attributes to work
esimkowitz
reviewed
May 2, 2024
| } | ||
|
|
||
| @mobxReact.observer | ||
| class AIChat extends React.Component<{}, {}> { |
There was a problem hiding this comment.
Can we not reuse more from the aichat auxview or maybe make that a component somewhere else that both views can utilize? Same for the keybindings
There was a problem hiding this comment.
currently doing this in another branch. can we skip it for this PR? 🙏
|
red, you're going to have to resolve the conflicts here -- including migrate to use clsx (instead of classnames) and the new "yarn modern". |
|
closing, since I think this is the old PR. I don't want to get confused. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.