Refactor the run command's search for files. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now searches for everything up-front. My main goal with this was to get towards having a list of what all we're going to do, so that we can make progress reports about how far along we are. The second half of that remains a long road ahead, but the first part is now significantly closer. It's now detected faster if you typo a filename, rather than potentially being noticed only after lots of other work has been done, which is a mild improvement. It also supports more than one "..." pattern now, although that was sort of a target-of-opportunity thing. Overall, this isn't a huge change itself, but cleans things up and separates some concerns nicely, and prepares they way for more. Bumps the go-fsx version, to get some more convenience functions. (I'm also starting to slowly increase our use of FS objects.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now searches for everything up-front.
My main goal with this was to get towards having a list of what all we're going to do, so that we can make progress reports about how far along we are. The second half of that remains a long road ahead, but the first part is now significantly closer.
It's now detected faster if you typo a filename, rather than potentially being noticed only after lots of other work has been done, which is a mild improvement.
It also supports more than one "..." pattern now, although that was sort of a target-of-opportunity thing.
Overall, this isn't a huge change itself, but cleans things up and separates some concerns nicely, and prepares they way for more.
Bumps the go-fsx version, to get some more convenience functions. (I'm also starting to slowly increase our use of FS objects.)