Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create light and dark themes based on Pop!_OS #88

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

DaveParr
Copy link
Contributor

Pull Request Template

Discord username (optional)

If you're in our Discord server, we'd like to give you the Contributor Discord Role, please include your username. Note: It must be labelled like so: username#4747 (make sure to include the #XXXX).

zimapurple

NB: Didn't discord depreceate the numbering system recently? Mine might have been 76884?

Name of theme

popos_light
popos_dark

How Has This Been Tested?

Have you run the python script? python3 ./scripts/gen_theme_previews.py <folder-name-eg-standard>

Yes

Notes

We cannot accept pull request that include custom background images because:

  • of licensing restrictions
  • we are trying to keep the binary size of the repo as small as possible (just the yaml files)

If your theme has an intended custom background image, include a comment in the yaml with a link to where people should download it.

@DaveParr
Copy link
Contributor Author

Looks like I might have picked up some left overs from #86 when I ran the python script.

@DaveParr
Copy link
Contributor Author

DaveParr commented Jun 9, 2024

heya, @elviskahoro what do you think?

Are you still interested in community themes or have maybe I made a mistake somewhere?

@elviskahoro
Copy link
Member

No mistake @DaveParr this is awesome! Thanks for submitting!

@elviskahoro elviskahoro merged commit 79ef139 into warpdotdev:main Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants