Implement Sablier Traefik Plugin for Workload Management #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navarr
requested changes
Feb 21, 2024
| @@ -9,7 +9,7 @@ services: | |||
| volumes: | |||
| - ${WARDEN_HOME_DIR}/etc/traefik/traefik.yml:/etc/traefik/traefik.yml | |||
| - ${WARDEN_HOME_DIR}/etc/traefik/dynamic.yml:/etc/traefik/dynamic.yml | |||
| - ${WARDEN_HOME_DIR}/ssl/certs:/etc/ssl/certs | |||
| - ${WARDEN_HOME_DIR}/ssl/certs:/etc/ssl/certs/warden | |||
There was a problem hiding this comment.
The SSL certificate location change is outside the scope of your PR
There was a problem hiding this comment.
The original mount ends up clobbering all the default system certificates. Preventing Traefik from downloading plugins due to SSL verification errors.
Could be split to a seperate PR, as it should affecting install any Traefik plugin
Den4ik
reviewed
Feb 22, 2024
| storage: | ||
| file: | ||
| sessions: | ||
| default-duration: 5m |
There was a problem hiding this comment.
I believe that this config should be configurable, because you could work on the code and don't use env much more time. You will lose console history if it will be closed by stoping environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implement the Sablier Traefik Plugin, allowing Warden to dynamic start and stop project containers on request rather than having to manage them with env up/down saving system resources for us forgetful people. Especially useful if your working on multiple large projects simultaneously, or for certain edge use cases (we run Warden also as a Ephemeral/Feature hosts deployment with a lot of projects for example).
Implementation Notes
WARDEN_SABLIER_ENABLE =1in the service.envTRAEFIK_SABLIER_DURATION=2h(How long before Sablier sleeps the containers)TRAEFIK_VERSION=2.9Configuration
Service Config:
WARDEN_SABLIER_ENABLE=0- Enables Sablier globally for the installation (Unable to think of a good use case of enablement on project basis)Project :
TRAEFIK_SABLIER_DURATION=30m- How long Sablier waits to sleep containersTRAEFIK_SABLIER_THEME=ghost- Sablier theme to use List of Default ThemesAdvanced:
${WARDEN_HOME_DIR}/etc/sablier/theme- Directory if you want to declare any custom Sablier Themes${WARDEN_HOME_DIR}/etc/sablier/sablier.yml- Sablier Service Configuration Overrides