security(weave): Fixing path traversal in send_local_file #1657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a path traversal vulnerability in weave_server.py, discovered by a bug bounty researcher
abspath = "/" / pathlib.Path(path)
constructs an absolute path by joining the root directory / with the provided path. It ensures that abspath always starts from the root directory, however - it doesn't protect against path traversal attacks. An attacker could give a path like../../../../../../../etc/passwd
and read sensitive files outside of the root directory of the webserver.The patch proposed in this PR checks to ensure that the resolved
requested_path
starts with thelocal_artifact_path
- otherwise throws a403
Error.