chore(weave): Set tag in sentry error boundary #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=170e8e6477ffb5974d78f0b78f58fc08719e4014 |
jwlee64
changed the title
jamie-rasmussen
approved these changes
May 23, 2024
| @@ -25,6 +26,12 @@ export class ErrorBoundary extends Component<Props, State> { | |||
| 'weave_panel_error_boundary', | |||
| weaveErrorToDDPayload(error) | |||
| ); | |||
|
|
|||
| Sentry.captureException(error, { | |||
There was a problem hiding this comment.
Do you happen to have a link to sentry docs for this API? I was wondering whether the tag value had to be a string and I couldn't find them.
There was a problem hiding this comment.
https://docs.sentry.io/platforms/javascript/enriching-events/tags/
"Tags are key/value string pairs"
Let me find the other one rq
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
captures weave error boundary errors in sentry and adds a tag to allow for easier navigation in sentry
internal jira https://wandb.atlassian.net/browse/WB-18548