chore(weave): Uses anon cookie, if no user is authed #1604
Conversation
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=3c427bb600cf74706955cec4a5a3b4752d06e63b |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=4a4b4e12fb2a7ec868bf5281072296bf5b5e066c |
| @@ -157,3 +157,14 @@ function getFirebaseCookiesObject(): Struct<string> { | |||
| return {}; | |||
| } | |||
| } | |||
|
|
|||
| export const generateCookieString = () => { | |||
There was a problem hiding this comment.
why not put this in the core pr where it is used?
There was a problem hiding this comment.
it looks like all the cookie helpers were in this file
| return ctx.user_id | ||
| if ctx.user_id: | ||
| return ctx.user_id | ||
| if ctx.cookies and ctx.cookies["anon_wandb"]: |
There was a problem hiding this comment.
i think it would be cleaner if the weave cache logic did not have to know about the specific cookies / cookie name. This feels like we are coupling network implementation details with cache details. Is there a way that the middleware layer could store the anon_wandb cookie value in the context in such a way that it is clearly an anonymous session id?
Note: these cookies should be considered "black box" inside the the weave application and are just forwarded to gorilla.
This pr does two things
adds a function to create a dummy cookie, that we use in the app to create a cookie for anon users
adds support that if a user is anon (no userid) that we use said cookie as their cache key