refactor(core): Merge filestream "loop_" files #7624
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merges
loop_process.go
,loop_transmit.go
andloop_feedback.go
into a singlefilestreamimpl.go
(open to naming suggestions). This makes the data flow a bit easier to see. One can think of these three goroutines as a single function that processes Updates, so it helps to see all the processing steps an Update undergoes in one place.I also made each
loop
function close its corresponding output stream on its own so that channels are closed near where they're pushed to. As a side effect, this simplifiesfilestream.Close()
.