Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent 2 sweep ini outline #7480

Open
wants to merge 28 commits into
base: nick/launch-agent-2-poc
Choose a base branch
from

Conversation

KyleGoyette
Copy link
Contributor

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.

  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

@KyleGoyette KyleGoyette changed the title ini outline agent 2 sweep ini outline Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 85.27919% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 75.04%. Comparing base (4cbaeea) to head (fae52f8).

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##           nick/launch-agent-2-poc    #7480       +/-   ##
============================================================
+ Coverage                    35.30%   75.04%   +39.74%     
============================================================
  Files                          115      541      +426     
  Lines                         8361    55945    +47584     
============================================================
+ Hits                          2952    41985    +39033     
- Misses                        5160    13552     +8392     
- Partials                       249      408      +159     
Flag Coverage Δ
func 43.34% <31.63%> (?)
system 62.34% <32.48%> (?)
unit 55.92% <85.27%> (+20.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/sdk/launch/_launch.py 81.29% <100.00%> (ø)
wandb/sdk/launch/agent/job_status_tracker.py 87.50% <100.00%> (ø)
wandb/sdk/launch/agent2/__init__.py 100.00% <100.00%> (ø)
wandb/sdk/launch/agent2/controllers/__init__.py 100.00% <100.00%> (ø)
.../launch/agent2/controllers/scheduler_controller.py 100.00% <100.00%> (ø)
wandb/sdk/launch/agent2/jobset.py 90.60% <100.00%> (ø)
wandb/sdk/launch/agent2/controller.py 96.55% <83.33%> (ø)
wandb/sdk/launch/agent2/controllers/k8s.py 69.69% <66.66%> (ø)
...b/sdk/launch/agent2/controllers/local_container.py 68.18% <66.66%> (ø)
wandb/sdk/launch/agent2/controllers/sagemaker.py 71.42% <75.00%> (ø)
... and 5 more

... and 480 files with indirect coverage changes

@KyleGoyette KyleGoyette marked this pull request as ready for review May 2, 2024 23:20
@KyleGoyette KyleGoyette requested a review from a team as a code owner May 2, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant