Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): clean up define metric and add missing functionality #7447

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Apr 22, 2024

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.

  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

@kptkin kptkin changed the title Kpt/major refactor chore(core): minor clean up Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 67.05202% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 72.64%. Comparing base (e95426d) to head (93bdcd5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7447      +/-   ##
==========================================
- Coverage   74.91%   72.64%   -2.28%     
==========================================
  Files         519      521       +2     
  Lines       54631    56177    +1546     
==========================================
- Hits        40928    40808     -120     
- Misses      13302    14972    +1670     
+ Partials      401      397       -4     
Flag Coverage Δ
func 43.35% <48.57%> (+0.07%) ⬆️
system 61.20% <82.14%> (-1.72%) ⬇️
unit 54.39% <20.23%> (-0.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/pkg/server/sender.go 63.08% <100.00%> (-9.75%) ⬇️
core/pkg/server/stream.go 96.58% <100.00%> (-1.34%) ⬇️
core/internal/runmetric/runmetric.go 50.00% <50.00%> (ø)
core/internal/runmetric/runmetric_sender.go 66.66% <66.66%> (ø)
core/pkg/server/handler.go 68.09% <58.13%> (-5.69%) ⬇️
core/internal/runmetric/runmetric_handler.go 65.62% <65.62%> (ø)

... and 100 files with indirect coverage changes

@kptkin kptkin changed the title chore(core): minor clean up refactor(core): clean up define metric and add missing functionality Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants