Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(artifacts): gzip manifest.json before uploading #7402

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moredatarequired
Copy link
Contributor

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.

  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

@moredatarequired
Copy link
Contributor Author

moredatarequired commented Apr 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @moredatarequired and the rest of your teammates on Graphite Graphite

@moredatarequired moredatarequired changed the title Gzip manifest.json before uploading feat(artifacts): gzip manifest.json before uploading Apr 17, 2024
@moredatarequired moredatarequired marked this pull request as ready for review April 17, 2024 22:59
@moredatarequired moredatarequired requested a review from a team as a code owner April 17, 2024 22:59
@moredatarequired moredatarequired marked this pull request as draft April 17, 2024 22:59
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 73.00%. Comparing base (db622f3) to head (fc2726a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7402      +/-   ##
==========================================
- Coverage   75.90%   73.00%   -2.91%     
==========================================
  Files         518      518              
  Lines       54537    54538       +1     
==========================================
- Hits        41396    39815    -1581     
- Misses      12762    14342    +1580     
- Partials      379      381       +2     
Flag Coverage Δ
func 43.25% <58.33%> (+0.01%) ⬆️
system 59.75% <58.33%> (-4.23%) ⬇️
unit 57.75% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/sdk/artifacts/artifact_saver.py 78.40% <58.33%> (-17.00%) ⬇️

... and 58 files with indirect coverage changes

@moredatarequired moredatarequired changed the base branch from use-bytesio-instead-of-tempfile to main April 18, 2024 00:49
@github-actions github-actions bot added cc-feat and removed cc-feat labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant