test(sdk): fix broken test in test_gpu_apple.py #7387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoffex
reviewed
Apr 16, 2024
| @@ -49,7 +49,7 @@ def test_gpu_apple(test_settings): | |||
| ) | |||
| assert gpu.is_available() | |||
| gpu.start() | |||
| assert gpu.probe() == {"gpuapple": {"type": "arm", "vendor": "Apple"}} | |||
| assert gpu.probe()["gpuapple"]["vendor"] == "sppci_vendor_Apple" | |||
There was a problem hiding this comment.
how did this succeed before in CI?
There was a problem hiding this comment.
we haven't been running this in ci...
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7387 +/- ##
==========================================
+ Coverage 75.53% 75.78% +0.25%
==========================================
Files 518 518
Lines 54535 54535
==========================================
+ Hits 41191 41329 +138
+ Misses 12962 12825 -137
+ Partials 382 381 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does the PR do? Include a concise description of the PR contents.
Testing
How was this PR tested?