fix(artifacts): correctly handle artifacts with 0-byte files with wandb-core #7321
Conversation
moredatarequired
force-pushed
the
handle-empty-files
branch
from
62046c5
to
25863eb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7321 +/- ##
==========================================
+ Coverage 76.23% 76.26% +0.03%
==========================================
Files 512 512
Lines 54338 54341 +3
==========================================
+ Hits 41422 41441 +19
+ Misses 12555 12535 -20
- Partials 361 365 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
moredatarequired
force-pushed
the
handle-empty-files
branch
from
910ecd0
to
0999f7a
Compare
| if task.Size == 0 { | ||
| // *Sometimes* on *some* platforms, req.Body is set to a non-nil io.Reader that | ||
| // would return 0 bytes if read, but net/http/Request.outgoingLength takes the | ||
| // presence of a body to indicate that length > 0 and "corrects" it to -1 to | ||
| // indicate unknown. If we don't fix it here we get 411 Length Required errors. | ||
| req.Body = io.NopCloser(bytes.NewReader([]byte{})) | ||
| task.Headers = append(task.Headers, "Content-Length:0") | ||
| } |
There was a problem hiding this comment.
i don't think you need to do it here, we are uploading empty files regularly when we use wandb.save pretty sure it is something artifact specific
There was a problem hiding this comment.
I can repro outside wandb just using the net/http library... How do you do it in wandb.save()?
There was a problem hiding this comment.
Note that the above fix doesn't even work. It sometimes does which is even weirder, but the net/http library is where the content-length gets rewritten and I haven't figured out how to force it to send a correct content length.
Description
Testing
How was this PR tested?