Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(launch): Remove internal api calls used when create job artifacts #7312

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KyleGoyette
Copy link
Contributor

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.

  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 76.28%. Comparing base (d779c09) to head (f3a7925).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7312      +/-   ##
==========================================
+ Coverage   76.26%   76.28%   +0.01%     
==========================================
  Files         510      510              
  Lines       54207    54217      +10     
==========================================
+ Hits        41339    41357      +18     
+ Misses      12516    12510       -6     
+ Partials      352      350       -2     
Flag Coverage Δ
func 43.80% <7.40%> (+0.08%) ⬆️
system 64.61% <81.48%> (+0.01%) ⬆️
unit 57.91% <14.81%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/sdk/internal/job_builder.py 94.46% <100.00%> (ø)
wandb/sdk/launch/create_job.py 76.85% <80.00%> (+0.14%) ⬆️

... and 9 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant