Skip to content

Commit

Permalink
docstrings
Browse files Browse the repository at this point in the history
  • Loading branch information
Amulya Musipatla authored and Amulya Musipatla committed May 6, 2024
1 parent cc892df commit 71b993e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 21 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Please add to the relevant subsections under Unreleased below on every PR where
* `wandb-core` now supports Artifact file caching by @moredatarequired in https://github.com/wandb/wandb/pull/7364 and https://github.com/wandb/wandb/pull/7366
* Added artifact_exists() and artifact_collection_exists() methods to Api to check if an artifact or collection exists by @amusipatla-wandb in https://github.com/wandb/wandb/pull/7483
* `wandb launch -u <git-uri | local-path> ` creates and launches a job from the given source code by @bcsherma in https://github.com/wandb/wandb/pull/7485
* Added save() method on ArtifactCollection to allow persisting changes by @amusipatla-wandb in https://github.com/wandb/wandb/pull/7555
* Added ArtifactCollection.save() by @amusipatla-wandb in https://github.com/wandb/wandb/pull/7555

### Fixed

Expand Down
20 changes: 0 additions & 20 deletions wandb/apis/public/artifacts.py
Original file line number Diff line number Diff line change
Expand Up @@ -530,11 +530,6 @@ def description(self):

@description.setter
def description(self, description: Optional[str]) -> None:
"""Set the description of the artifact collection.
Arguments:
description: (str) Free text that offers a description of the artifact collection.
"""
self._description = description

@property
Expand All @@ -544,11 +539,6 @@ def tags(self):

@tags.setter
def tags(self, tags: List[str]) -> None:
"""Set the tags associated with the artifact collection.
Arguments:
tags: (List[str]) List of tag names to set the collection's tags to.
"""
if any(char in tag for tag in tags for char in ["/", ":"]):
raise ValueError(

Check warning on line 543 in wandb/apis/public/artifacts.py

View check run for this annotation

Codecov / codecov/patch

wandb/apis/public/artifacts.py#L543

Added line #L543 was not covered by tests
"Tags must not contain any of the following characters: /, :"
Expand All @@ -562,11 +552,6 @@ def name(self):

@name.setter
def name(self, name: List[str]) -> None:
"""Set the name of the artifact collection.
Arguments:
name: (str) Name to change the collection name to.
"""
self._name = name

@property
Expand All @@ -576,11 +561,6 @@ def type(self):

@type.setter
def type(self, type: List[str]) -> None:
"""Set the type of the artifact collection.
Arguments:
type: (str) The type to change the collection to.
"""
if not self.is_sequence():
raise ValueError(
"Type can only be changed if the artifact collection is a sequence."
Expand Down

0 comments on commit 71b993e

Please sign in to comment.