feat: Add operator helm release #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityachoudhari26
changed the title
| @@ -154,7 +154,8 @@ module "gke_app" { | |||
| local_restore = var.local_restore | |||
| other_wandb_env = merge({ | |||
| "GORILLA_DISABLE_CODE_SAVING" = var.disable_code_saving, | |||
| "GORILLA_CUSTOMER_SECRET_STORE_SOURCE" = local.secret_store_source | |||
| "GORILLA_CUSTOMER_SECRET_STORE_SOURCE" = local.secret_store_source, | |||
| "GORILLA_GLUE_LIST" = var.enable_operator | |||
There was a problem hiding this comment.
when GORILLA_GLUE_LIST is true, it disables glue tasks for that pod. So if operator feature flag is on, disable glue task execution in old pod
| issuer = { create = true, provider = "google" } | ||
| annotations = { | ||
| "kubernetes.io/ingress.class" = "gce" | ||
| "kubernetes.io/ingress.global-static-ip-name" = module.app_lb.address_operator_name |
There was a problem hiding this comment.
ingress will point to newly provisioned IP address for simplicity
* fix: Backwards compatibility for t-shirt-sized deployments * empty * empty
### [1.23.1](v1.23.0...v1.23.1) (2024-02-21) ### Bug Fixes * Backwards compatibility for t-shirt-sized deployments ([#101](#101)) ([f812f81](f812f81))
* fix: backwards compatibility fix to avoid changes in nodegroups. * terraform-docs: automated action * update example --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: George Scott <[email protected]>
### [1.23.2](v1.23.1...v1.23.2) (2024-02-22) ### Bug Fixes * Backwards compatibility fix to avoid changes in nodegroups. ([#102](#102)) ([c331853](c331853))
adityachoudhari26
force-pushed
the
operator-google-p1
branch
from
6b80dfe
to
7ba81d3
Compare
| host = local.url | ||
| license = var.license | ||
|
|
||
| extraEnv = merge({ |
There was a problem hiding this comment.
Are you missing the inverse GORILLA_GLUE_LIST logic here?
zacharyblasczyk
approved these changes
Mar 2, 2024
wandb-kc
approved these changes
Mar 2, 2024
|
This PR is included in version 1.24.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.