-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for t-shirt-sized deployments #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atabase (#92) * feat: Update redis reserved ip range * update * parameterize redis reserved ip range * Adds instance deletion protection on cloud sql * terraform-docs: automated action * fix fmt * update --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
## [1.22.0](v1.21.0...v1.22.0) (2023-12-15) ### Features * Update redis reserved ip range and Add deletion protection to database ([#92](#92)) ([c5ec027](c5ec027))
namespace = var.namespace | ||
license = var.license | ||
domain_name = var.domain_name | ||
subdomain = var.subdomain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing?
yogeshg
reviewed
Feb 12, 2024
gls4
approved these changes
Feb 21, 2024
This PR is included in version 1.23.0 🎉 |
yogeshg
reviewed
Feb 21, 2024
|
||
output "gke_node_count" { | ||
value = local.deployment_size[var.size].node_count |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these need try too
adityachoudhari26
added a commit
that referenced
this pull request
Mar 4, 2024
* add new infra alongside existing infra * terraform-docs: automated action * weave install false while rwo being implemented * add boolean flag * terraform-docs: automated action * better var name * terraform-docs: automated action * weave install true test * add wandb_replicas logic for gke app * terraform-docs: automated action * add license and extraenvs * correct caCertPath for redis * minimal spec * re-add bucket, mysql, and redis * add other wandb env * add all but extra envs * add extraEnv * unneeded comma * redis cert path follows helm charts * add depends on * correct controller image tag * add envs * rebase * chore(release): version 1.23.0 [skip ci] ## [1.23.0](v1.22.0...v1.23.0) (2024-02-21) ### Features * Add support for t-shirt-sized deployments ([#91](#91)) ([5432961](5432961)), closes [#92](#92) * fix: Backwards compatibility for t-shirt-sized deployments (#101) * fix: Backwards compatibility for t-shirt-sized deployments * empty * empty * chore(release): version 1.23.1 [skip ci] ### [1.23.1](v1.23.0...v1.23.1) (2024-02-21) ### Bug Fixes * Backwards compatibility for t-shirt-sized deployments ([#101](#101)) ([f812f81](f812f81)) * fix: Backwards compatibility fix to avoid changes in nodegroups. (#102) * fix: backwards compatibility fix to avoid changes in nodegroups. * terraform-docs: automated action * update example --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: George Scott <[email protected]> * chore(release): version 1.23.2 [skip ci] ### [1.23.2](v1.23.1...v1.23.2) (2024-02-22) ### Bug Fixes * Backwards compatibility fix to avoid changes in nodegroups. ([#102](#102)) ([c331853](c331853)) * rebase * rebase * rebase * terraform-docs: automated action * pull out ssl certificate id * specify which https for putput * remove issuer create tag from ingress * add inverse gorilla glue logic --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Yogesh Garg <[email protected]> Co-authored-by: George Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.