Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Google Secret Manager #89

Merged
merged 6 commits into from
Oct 27, 2023
Merged

feat: Add support for Google Secret Manager #89

merged 6 commits into from
Oct 27, 2023

Conversation

andrewtruong
Copy link
Contributor

@andrewtruong andrewtruong commented Oct 23, 2023 •
edited
Loading

Adds support for Google Secret Manager and W&B Secrets using that backend

Tested webhooks e2e on a fresh instance

@andrewtruong andrewtruong requested a review from a team October 23, 2023 01:35
@andrewtruong andrewtruong requested a review from a team as a code owner October 23, 2023 01:35
@andrewtruong andrewtruong changed the title feat: Add support for Google Secrets Manager feat: Add support for Google Secret Manager Oct 23, 2023
jsbroks
jsbroks requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@jsbroks jsbroks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to block on name changes because they are VERY hard to refactor

main.tf Outdated Show resolved Hide resolved
@jsbroks
Copy link
Member

jsbroks commented Oct 23, 2023

Can we move the permission into modules/service_accounts

gls4
gls4 suggested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@gls4 gls4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think the service account needs to be placed in the service_accounts module with the other service accounts, instead of its own. I made some other comments regarding the scope of permissions and the project id as well.

modules/google_secret_manager/main.tf Outdated Show resolved Hide resolved
modules/google_secret_manager/variables.tf Outdated Show resolved Hide resolved
@andrewtruong
Copy link
Contributor Author

Can we move the permission into modules/service_accounts

Yes, and doing so eliminates the need for a secrets module altogether

@andrewtruong andrewtruong merged commit 8eb6b98 into main Oct 27, 2023
3 checks passed
@andrewtruong andrewtruong deleted the andrew/secrets branch October 27, 2023 16:00
jsbroks pushed a commit that referenced this pull request Oct 27, 2023
@semantic-release-bot
chore(release): version 1.21.0 [skip ci]
d05fc65 
## [1.21.0](v1.20.2...v1.21.0) (2023-10-27)

### Features

* Add support for Google Secret Manager ([#89](#89)) ([8eb6b98](8eb6b98))
@jsbroks
Copy link
Member

jsbroks commented Oct 27, 2023

This PR is included in version 1.21.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gls4 gls4 gls4 approved these changes

@jsbroks jsbroks jsbroks approved these changes

@wandb-kc wandb-kc wandb-kc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewtruong @jsbroks @gls4 @wandb-kc