Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix ssl certificate recreation #86

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix: Fix ssl certificate recreation #86

merged 1 commit into from
Oct 5, 2023

Conversation

flamarion
Copy link
Contributor

fix: Fix ssl certificate recreation

@flamarion flamarion marked this pull request as ready for review October 5, 2023 13:21
@flamarion flamarion requested a review from gls4 as a code owner October 5, 2023 13:21
@flamarion flamarion requested a review from a team October 5, 2023 13:21
@flamarion flamarion requested a review from a team as a code owner October 5, 2023 13:21
@flamarion
Copy link
Contributor Author

The apply pointing to the branch with the effective change
https://app.terraform.io/app/weights-and-biases/workspaces/customer-merantix/runs/run-mLk6GepMnB3P44QC

The new run without any change to validate the change will not recreate the cert repeatedly, only if the subdomain changes.

https://app.terraform.io/app/weights-and-biases/workspaces/customer-merantix/runs/run-QqhbxuCRBxMxcYpU

@flamarion
Copy link
Contributor Author

flamarion commented Oct 5, 2023 •
edited
Loading

Here is a new run changing the subdomain because it was incorrect.

https://app.terraform.io/app/weights-and-biases/workspaces/customer-merantix/runs/run-6eUp7jxoKEHquamm

@gls4 gls4 merged commit 8d0e800 into main Oct 5, 2023
7 checks passed
@gls4 gls4 deleted the fix_ssl_certificate_recriation branch October 5, 2023 15:45
jsbroks pushed a commit that referenced this pull request Oct 5, 2023
@semantic-release-bot
chore(release): version 1.19.2 [skip ci]
fef31b5 
### [1.19.2](v1.19.1...v1.19.2) (2023-10-05)

### Bug Fixes

* Fix ssl certificate recreation ([#86](#86)) ([8d0e800](8d0e800))
@jsbroks
Copy link
Member

jsbroks commented Oct 5, 2023

This PR is included in version 1.19.2 🎉

gls4 pushed a commit that referenced this pull request Oct 5, 2023
@flamarion
fix: Fix ssl certificate recreation (#86)
6e8952c
gls4 pushed a commit that referenced this pull request Oct 5, 2023
@semantic-release-bot
chore(release): version 1.19.2 [skip ci]
3ee4641 
### [1.19.2](v1.19.1...v1.19.2) (2023-10-05)

### Bug Fixes

* Fix ssl certificate recreation ([#86](#86)) ([8d0e800](8d0e800))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gls4 gls4 gls4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flamarion @jsbroks @gls4