Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added t-shirt size support #135

Merged
merged 3 commits into from
Jun 21, 2024
Merged

feat: Added t-shirt size support #135

merged 3 commits into from
Jun 21, 2024

Conversation

amanpruthi
Copy link
Collaborator

No description provided.

@amanpruthi amanpruthi requested a review from a team as a code owner June 7, 2024 10:27
@amanpruthi amanpruthi linked an issue Jun 7, 2024 that may be closed by this pull request
@zacharyblasczyk
Copy link
Contributor

Have you tested this?
We have had problems with other cloud providers when they try and change the node groups is why I ask.

@amanpruthi
Copy link
Collaborator Author

amanpruthi commented Jun 21, 2024

We have tested small , large and xlarge t-shirt sizes, didn't face any issue. may its because we have tested it in sandbox account( externaldevops project).

@amanpruthi amanpruthi merged commit f8a3a2f into main Jun 21, 2024
6 checks passed
@amanpruthi amanpruthi deleted the aman/tshirt-size branch June 21, 2024 08:29
jsbroks pushed a commit that referenced this pull request Jun 21, 2024
## [3.4.0](v3.3.0...v3.4.0) (2024-06-21)

### Features

* Added t-shirt size support ([#135](#135)) ([f8a3a2f](f8a3a2f))
@jsbroks
Copy link
Member

jsbroks commented Jun 21, 2024

This PR is included in version 3.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add t-shirt sizing for GCP instances
3 participants