Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update README.md for public-dns-with-cloud-dns example #130

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

danielpanzella
Copy link
Contributor

Added required and renamed values to the example tfvars

  • allowed_inbound_cidrs is a required variable
  • domain seems to have renamed to domain_name

@danielpanzella danielpanzella changed the title Update README.md docs: Update README.md for public-dns-with-cloud-dns example Jun 5, 2024
@danielpanzella danielpanzella marked this pull request as ready for review June 5, 2024 17:34
@danielpanzella danielpanzella requested a review from a team as a code owner June 5, 2024 17:34
@danielpanzella danielpanzella merged commit f8c94a0 into main Jun 5, 2024
6 checks passed
@danielpanzella danielpanzella deleted the danielpanzella-patch-1 branch June 5, 2024 17:51
@jsbroks
Copy link
Member

jsbroks commented Jun 5, 2024

This PR is included in version 3.0.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants