Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Golang to 1.21 #505

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump Golang to 1.21 #505

wants to merge 1 commit into from

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Feb 5, 2024

No description provided.

@gliptak
Copy link
Contributor Author

gliptak commented Feb 5, 2024

should golintci/static-analysis exclude dependent packages?

https://github.com/wagoodman/dive/actions/runs/7788571006/job/21238257819?pr=505

./.tmp/golangci-lint run --tests=false --timeout=2m --config .golangci.yaml
Error: ../../../../../opt/hostedtoolcache/go/1.21.6/x64/src/net/http/internal/chunked.go:7[9](https://github.com/wagoodman/dive/actions/runs/7788571006/job/21238257819?pr=505#step:4:10):14: undefined: max (typecheck)
	cr.excess = max(cr.excess, 0)
	            ^
Error: ../../../go/pkg/mod/github.com/docker/[email protected]+incompatible/client/request.go:9:2: "net" imported and not used (typecheck)
	"net"
	^

@gliptak
Copy link
Contributor Author

gliptak commented Feb 6, 2024

@wagoodman please review

@gliptak gliptak closed this Apr 26, 2024
@gliptak gliptak reopened this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gliptak