Make DeviceMotionEventInit members nullable with null default #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reverts #55 and defines the default values of the DeviceMotionEventInit as null as I believe was the original intent of the definition before that change. Null DeviceMotionEvent attributes have semantic meaning (they declare that the host does not provide the given sensor) and so script should be able to initialize an event with its attributes set to null. Fixed #91.
annevk
reviewed
Feb 29, 2024
Comment on lines
+510
to
+512
| DeviceMotionEventAccelerationInit? acceleration = null; | ||
| DeviceMotionEventAccelerationInit? accelerationIncludingGravity = null; | ||
| DeviceMotionEventRotationRateInit? rotationRate = null; |
There was a problem hiding this comment.
What if you default these to {} instead?
|
@reillyeon, what would you like to do here? See @annevk suggestion. As the events are primarily fired by the browser, we can make these defaults as implementation friendly as possible. |
|
@marcoscaceres see #91 (comment) for context. At this point we're waiting for @rakuco I think. |
|
Ah, right, thanks!... @rakuco, do you want me to take this over? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reverts #55 and defines the default values of the DeviceMotionEventInit as null as I believe was the original intent of the definition before that change.
Null DeviceMotionEvent attributes have semantic meaning (they declare that the host does not provide the given sensor) and so script should be able to initialize an event with its attributes set to null.
Fixed #91.
Preview | Diff