Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accname PR 183] Step 2C includes controls with value that are directly referenced by labelledby or describedby #2210

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pkra
Copy link
Member

@pkra pkra commented May 23, 2024

Moved from w3c/accname#183

@pkra
Copy link
Member Author

pkra commented May 23, 2024

This move was a bit messier since the PR is a year old and had merge conflicts.

I fixed two details which I hope are editorial:

  • I restored the deleted space after "combobox" (second changed line) seems erroneous.
  • I changed the closing ol tag to a closing ul tag to match the change in the opening tag.

@smhigley could you please double check when you find the time?

@pkra pkra force-pushed the monorepo_history--accname-PR183 branch from dc15b14 to 405fb4f Compare May 23, 2024 14:25
@pkra
Copy link
Member Author

pkra commented May 23, 2024

Ugh - I had forgotten to stage the fixed merge conflicts. I've force pushed the correct merge now.

@pkra pkra changed the base branch from monorepo_history--accname to main June 12, 2024 19:32
@pkra pkra changed the title [Monorepo] [accname PR 183] Step 2C includes controls with value that are directly referenced by labelledby or describedby [accname PR 183] Step 2C includes controls with value that are directly referenced by labelledby or describedby Jun 12, 2024
@pkra
Copy link
Member Author

pkra commented Jun 12, 2024

Now pointing to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants