Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests root record #907

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

mzgoddard
Copy link
Contributor

@mzgoddard mzgoddard commented Mar 9, 2023

Preview Tests

This change makes some changes I thought would be good to implement while working on #904.

  • reduce repeated calls of path.dirname and path.basename on the same arguments
    • of note is path.basename(directory)
  • base existingBuild and newBuild on the root directory instead of build directory
    • additionally update inline-scripted reference html files in the source test plan directory with FileRecordChain

@jugglinmike
Copy link
Contributor

Heads up: I won't be able to review this until I can run the build script.

@jugglinmike jugglinmike removed their request for review February 22, 2024 19:03
@jugglinmike
Copy link
Contributor

This branch now conflicts with the target branch. Because this has been open for a while, there's a possibility that the conflicts are substantial, so I'd prefer to wait on reviewing until after those have been addressed.

@mzgoddard
Copy link
Contributor Author

@jugglinmike I rebased onto master and fixed the conflicts and reproduced the changes on process-test-directory.js.

Copy link
Contributor

@jugglinmike jugglinmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, and I've verified that its output is identical for the current "v1" and "v2" test plans.

That said, I spoke with Howard about the existing duplication in this file, and he had this to say:

v1 csv resources and references eventually won't exist so there won't be a need to build them. A couple v1 files have already been removed since introducing v2

So separating that into dedicated orchestrating scripts for the v1 and v2 test formats rather than creating branches in a single file that we may want to eventually prune in the future seemed much easier to do

Some parts are similar enough though that the functions could be consolidated in a single util and used separately

But a large majority of them felt like it would still adding a separate branch only to prune in the future from what I can remember and felt unnecessary, in that moment at least

Does that context impact that way you'd like to structure this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants