Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CollectionJob mutations into CollectionJobOperations where appropriate #930

Closed
wants to merge 3 commits into from

Conversation

stalgiag
Copy link
Contributor

@stalgiag stalgiag commented Feb 16, 2024

This PR moves all of the mutation resolvers that are contextual to an existing CollectionJob into CollectionJobOperations.

These are :

  • deleteCollectionJob
  • restartCollectionJob
  • updateCollectionJob

These changes make are intended to make the GraphQL interface for CollectionJobs more organized and clear.

@alflennik
Copy link
Contributor

@stalgiag are you ready for the team to review? If so go ahead and assign someone?

@stalgiag
Copy link
Contributor Author

@stalgiag are you ready for the team to review? If so go ahead and assign someone?

Thanks for checking in. I've intentionally let this sit on the vine as this was a lower priority and I thought it better to let #943 land first since it would likely necessitate some changes in this one.

@howard-e howard-e changed the base branch from main to development April 4, 2024 22:25
@stalgiag
Copy link
Contributor Author

stalgiag commented Jun 6, 2024

Closing as this small debt task coincided with some larger changes and the conflicts are so substantial that this task should be started over.

@stalgiag stalgiag closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants