Add AT version column to Test Queue #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
requested changes
May 16, 2024
There was a problem hiding this comment.
@alflennik thanks for getting this done so quickly! The column looks good and left a few inline comments.
The main blocker here is that when assigning and unassigning myself or others to any report, it crashes the page. Could you take a look at why?
server/resources/ats.json
Outdated
| @@ -6,9 +6,8 @@ | |||
| "defaultConfigurationInstructionsHTML": "Configure JAWS with default settings. For help, read <a href="https://github.com/w3c/aria-at/wiki/Configuring-Screen-Readers-for-Testing">Configuring Screen Readers for Testing</a>.", | |||
There was a problem hiding this comment.
Looks like you're accidentally removing newly added tokens coming from w3c/aria-at. You may want to remove these changes.
| @@ -530,6 +530,11 @@ const TestQueueRow = ({ | |||
| <LoadingStatus message={loadingMessage}> | |||
| <tr className="test-queue-run-row"> | |||
| <th>{renderAssignedUserToTestPlan()}</th> | |||
| <td style={{ padding: '0.75rem' }}> | |||
There was a problem hiding this comment.
We don't do these inline styles but considering this is only temporary patch, it's fine!
| @@ -102,6 +102,7 @@ const TestQueue = () => { | |||
| <thead> | |||
| <tr> | |||
| <th className="test-plan">Test Plan</th> | |||
| <th className="test-plan">AT Version</th> | |||
There was a problem hiding this comment.
Suggested change
| <th className="test-plan">AT Version</th> | |
| <th className="test-plan">AT Version Requirements</th> |
That language may be preferred.
howard-e
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.