Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include Trend Reports table on reports page #1092

Merged
merged 4 commits into from
May 21, 2024
Merged

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented May 9, 2024

Address #1083 and implements the design shared in #963 (comment).

This PR adds a versions summary and results table on the final reports page (AT + Browser report page): /reports/<id>/targets/<id>

@howard-e howard-e changed the title Trends table feat: Include Trend Reports table on reports page May 9, 2024
@howard-e howard-e marked this pull request as ready for review May 9, 2024 16:09
@howard-e howard-e requested review from alflennik and gnarf May 9, 2024 16:18
Copy link
Contributor

@gnarf gnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty simple and straight forward. 👍

Might be worth adding some simple tests for things like only showing for recommended reports, but I wouldn't necessarily block on this

@ccanash ccanash removed the request for review from alflennik May 16, 2024 15:44
@howard-e
Copy link
Contributor Author

Might be worth adding some simple tests for things like only showing for recommended reports, but I wouldn't necessarily block on this

Thanks! Will follow this up in another PR in an effort to prioritize a sandbox deploy

@howard-e howard-e merged commit 937bf44 into trends May 21, 2024
2 checks passed
@howard-e howard-e deleted the trends-table branch May 21, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants