This repository has been archived by the owner on Dec 2, 2019. It is now read-only.
Compiler warning fix and two sanity changes #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumblob
suggested changes
Sep 16, 2019
| @@ -18545,7 +18545,6 @@ nk_tree_element_image_push_hashed_base(struct nk_context *ctx, enum nk_tree_type | |||
| struct nk_vec2 item_spacing; | |||
| struct nk_rect header = {0,0,0,0}; | |||
| struct nk_rect sym = {0,0,0,0}; | |||
| struct nk_text text; | |||
There was a problem hiding this comment.
Hi, thanks for the fixes. I totally forgot why we wanted to set/change background in this function - did you try to semantically analyze where it would fit?
Also please bump version in CHANGELOG, thanks 😉.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was annoyed by nuklear not cleanly building so I set out to fix that.
I also fixed some issuse I've spotted along the way.